::-moz-focus-inner: remove unnecessary specificity#847
Open
mattbrundage wants to merge 1 commit intonecolas:masterfrom
Open
::-moz-focus-inner: remove unnecessary specificity#847mattbrundage wants to merge 1 commit intonecolas:masterfrom
mattbrundage wants to merge 1 commit intonecolas:masterfrom
Conversation
Updated to use the same specificity as in Mozilla's user agent stylesheet (``resource://gre-resources/forms.css``) Also, this ``::-moz-focus-inner`` rule has no effect on the primary focus style of buttons, so we don't have to "restore" focus styles with a ``:-moz-focusring`` rule. ``:-moz-focusring`` styles are set in ``resource://gre-resources/html.css`` Reduced test case: https://codepen.io/mattbrundage/pen/LYZKNYJ
garrettw
added a commit
to garrettw/vitals
that referenced
this pull request
Dec 14, 2020
marella
added a commit
to marella/modernize
that referenced
this pull request
Jun 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to use the same specificity as in Mozilla's user agent stylesheet (
resource://gre-resources/forms.css)Also, this
::-moz-focus-innerrule has no effect on the primary focus style of buttons, so we don't have to "restore" focus styles with a:-moz-focusringrule.:-moz-focusringstyles are set inresource://gre-resources/html.cssReduced test case: https://codepen.io/mattbrundage/pen/LYZKNYJ