Fix Android/IOS annotation layer ordering for markers, polylines and polygons#121
Open
Siergiej29 wants to merge 2 commits into
Open
Conversation
Siergiej29
changed the title
farfromrefug
requested changes
May 22, 2026
| // Register this bridge for the created MapView | ||
| MapboxBridge.registerBridge(self, for: mv) | ||
|
|
||
| pointAnnotationManager = mv.annotations.makePointAnnotationManager(id: MapboxBridge.MARKER_LAYER_ID) |
Member
There was a problem hiding this comment.
Why do you instantiate here when you are already doing it later when accessed?
| if polygonAnnotationManager == nil { | ||
| polygonAnnotationManager = mv.annotations.makePolygonAnnotationManager() | ||
| polygonAnnotationManager = mv.annotations.makePolygonAnnotationManager( | ||
| id: "mapbox-ios-polygons", |
Member
There was a problem hiding this comment.
Could you use a static property for the name here too, as you use it in multiple places ?
| if polylineAnnotationManager == nil { | ||
| polylineAnnotationManager = mv.annotations.makePolylineAnnotationManager() | ||
| polylineAnnotationManager = mv.annotations.makePolylineAnnotationManager( | ||
| id: "mapbox-ios-polylines", |
Member
There was a problem hiding this comment.
Could you use a static property for the name here too, as you use it in multiple places ?
Member
|
@Siergiej29 Thank you for this. I made a few comments if you don't mind. Then I ll release it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Android ans iOS, annotation layer ordering can cause markers to render below polylines or polygons.
Changes
This PR updates the Android/iOS annotation manager configuration to use the marker layer ID consistently when creating:
Result
Markers render above other annotation layers more consistently.
Scope
Android/iOS