fix: expose iteratee and update deprecated integrations#34
Open
canmertc wants to merge 1 commit into
Open
Conversation
Refactor Sentry integrations to expose the frame iteratee as frameIteratee and adopt the newer @sentry/integrations factory exports (rewriteFramesIntegration, httpClientIntegration). Replace internal calls to rewriteFrameIntegration._iteratee with direct frameIteratee(...) invocations across client.ts, wrapper.android.ts, and wrapper.ios.ts so native JS stacks can be rewritten without reaching into integration internals.
Member
farfromrefug
left a comment
farfromrefug
left a comment
There was a problem hiding this comment.
Nice did you test your changes with http integration too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
There was some logic in
client.ts,wrapper.android.ts, andwrapper.ios.tsthat used to access iteratee via the integration object. So removing the_iterateeassignment in #33 broke this link while passing iteratee to theRewriteFramesconstructor fixed the missing source snippet issue for the native errors andcaptureExceptioncalls.Fix
Exported frame iteratee as
frameIteratee. ReplacedrewriteFrameIntegration._iterateewith directframeIteratee(...)so the stacks can be rewritten without reaching into integration internals.Adopted the newer
@sentry/integrationsfactory exports (rewriteFramesIntegration,httpClientIntegration) as theRewriteFrames, andHttpClientare deprecated.