Skip to content

Improve ability to install extension#3

Open
networkfusion wants to merge 1 commit intomainfrom
networkfusion-fix-rate-limit
Open

Improve ability to install extension#3
networkfusion wants to merge 1 commit intomainfrom
networkfusion-fix-rate-limit

Conversation

@networkfusion
Copy link
Copy Markdown
Member

Removes need to use the GH API in most circumstances.

Description

Use the latest VS2022 extension, unless VS2019 is installed.

Motivation and Context

  • VS2019 is unlikely to be installed and used in a CI environment
  • API rate limites were a cause for concern.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

Removes need to use the GH API in most circumstances.
@nfbot nfbot changed the title Improve ability to install extension. Improve ability to install extension Dec 8, 2023
@josesimoes
Copy link
Copy Markdown
Member

This won't work because the "latest" from github repo can be VS2022 or VS2019, depending on the order the releases were released. Or if there was a release for 2019 and none for 2022. Or the other way around.

Only with direct calls to github API we can get this info reliably, that's why the current implementation is relying on the GH CLI.
But if you set the github token, as instructed bu github docs, you'll hardly hit the rate count...

Copy link
Copy Markdown
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above please.

@josesimoes josesimoes force-pushed the main branch 2 times, most recently from 389a771 to cda1a39 Compare April 21, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants