fix(core): Fix for execution history when flow includes wait node #23146
+215
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds 2 tests to verify timing for executions, waiting and resuming should not impact start time.
n8n-assistant
bot
added
core
|
Found 3 test failures on Blacksmith runners: Failures
|
|
E2E Tests: n8n tests failed after 6m 43.1s Run Details
Failed Spec Files
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
…flow-includes-wait-node
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
shortstacked
approved these changes
Dec 12, 2025
Contributor
shortstacked
left a comment
shortstacked
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Contributor
Author
|
@tomi Can I get your thoughts on these changes please 🙏 ? Explanation: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The workflow execution start time is set via
setRunningfunction, which is fired from multiple places. When the workflow is resumed after waiting, the same function is fired which results with overwrittenconst startedAt = new Date();- causing the bug with wrong execution time.Loom Recording
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-1854/execution-history-incorrect-when-flow-includes-wait-node
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)