Skip to content

Conversation

@dariacodes
Copy link
Contributor

Summary

Before:
image

After:
image

Related Linear tickets, Github issues, and Community forum posts

Closes ADO-4482

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Dec 12, 2025
@Joffcom
Copy link
Member

Joffcom commented Dec 12, 2025

@dariacodes this feels like a potential breaking change, If a user has worked around this in their workflow the new output may be unexpected. This will likely need a light version and a test to cover the change.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (all 1 issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/nodes-base/nodes/Set/v2/helpers/utils.ts">

<violation number="1" location="packages/nodes-base/nodes/Set/v2/helpers/utils.ts:186">
P1: Rule violated: **Tests**

This bug fix adds Date-to-string conversion but lacks a corresponding test. Existing tests in `packages/nodes-base/nodes/Set/test/v2/utils.test.ts` cover all other type conversions (number, array, object, boolean, undefined) for `validateEntry`, but Date is missing. Add a test like:

```typescript
it(&#39;should convert Date to ISO string&#39;, () =&gt; {
  const testDate = new Date(&#39;2025-01-15T12:00:00.000Z&#39;);
  const result = validateEntry(&#39;foo&#39;, &#39;string&#39;, testDate, node, 0);

  expect(result).toEqual({
    name: &#39;foo&#39;,
    value: &#39;2025-01-15T12:00:00.000Z&#39;,
  });
});
```</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...es/nodes-base/nodes/DataTable/common/selectMany.ts 75.00% 3 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@dariacodes dariacodes marked this pull request as draft December 12, 2025 12:09
@currents-bot
Copy link

currents-bot bot commented Dec 12, 2025

E2E Tests: n8n tests passed after 5m 17.3s

🟢 69 · 🔴 0 · ⚪️ 1 · 🟣 1

View Run Details

Run Details

  • Project: n8n

  • Groups: 1

  • Framework: Playwright

  • Run Status: Passed

  • Commit: f0612d6

  • Spec files: 121

  • Overall tests: 559

  • Duration: 5m 17.3s

  • Parallelization: 1


This message was posted automatically by currents.dev | Integration Settings

@blacksmith-sh

This comment has been minimized.

@dariacodes dariacodes changed the title fix(Set Node): Convert dates to strings correctly fix(Data Table Node): Convert dates to ISO strings in the output Dec 12, 2025
@dariacodes dariacodes marked this pull request as ready for review December 12, 2025 15:35
@dariacodes dariacodes requested a review from autologie December 12, 2025 15:35
@dariacodes
Copy link
Contributor Author

@Joffcom Good point! I ended up fixing this on Data Table node and created a new version. I had to introduce a conditional logic in the code, but I don't see a better way

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Copy link
Contributor

@autologie autologie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blacksmith-sh

This comment has been minimized.

@dariacodes dariacodes merged commit a3971d8 into master Dec 15, 2025
53 of 59 checks passed
@dariacodes dariacodes deleted the ado-4482-bug-set-node-incorrectly-converts-dates-to-string branch December 15, 2025 10:06
@github-actions github-actions bot mentioned this pull request Dec 15, 2025
@n8n-assistant
Copy link

n8n-assistant bot commented Dec 15, 2025

Got released with n8n@n8n@2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

n8n team Authored by the n8n team node/improvement New feature or request Released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants