-
Notifications
You must be signed in to change notification settings - Fork 52.1k
fix(Data Table Node): Convert dates to ISO strings in the output #23123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Data Table Node): Convert dates to ISO strings in the output #23123
Conversation
|
@dariacodes this feels like a potential breaking change, If a user has worked around this in their workflow the new output may be unexpected. This will likely need a light version and a test to cover the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/nodes-base/nodes/Set/v2/helpers/utils.ts">
<violation number="1" location="packages/nodes-base/nodes/Set/v2/helpers/utils.ts:186">
P1: Rule violated: **Tests**
This bug fix adds Date-to-string conversion but lacks a corresponding test. Existing tests in `packages/nodes-base/nodes/Set/test/v2/utils.test.ts` cover all other type conversions (number, array, object, boolean, undefined) for `validateEntry`, but Date is missing. Add a test like:
```typescript
it('should convert Date to ISO string', () => {
const testDate = new Date('2025-01-15T12:00:00.000Z');
const result = validateEntry('foo', 'string', testDate, node, 0);
expect(result).toEqual({
name: 'foo',
value: '2025-01-15T12:00:00.000Z',
});
});
```</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
E2E Tests: n8n tests passed after 5m 17.3s Run Details
This message was posted automatically by
currents.dev | Integration Settings
|
This comment has been minimized.
This comment has been minimized.
|
@Joffcom Good point! I ended up fixing this on Data Table node and created a new version. I had to introduce a conditional logic in the code, but I don't see a better way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 3 files
…-dates-to-string
autologie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This comment has been minimized.
This comment has been minimized.
|
Got released with |
Summary
Before:

After:

Related Linear tickets, Github issues, and Community forum posts
Closes ADO-4482
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)