-
Notifications
You must be signed in to change notification settings - Fork 3
feat: support user-defined custom check runs #961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
c2a367f
fix: improve Custom Check Runs robustness and security
rnetser 674b371
refactor: simplify custom-check-runs to trust-based model
rnetser a3c6b82
refactor: change custom check env from object to list of variable names
rnetser 2a613d8
docs: add env var usage example to custom-check-runs schema
rnetser 0c1f5ca
refactor: align custom checks with built-in check behavior
rnetser 5637f5e
feat: support explicit values in custom check env vars
rnetser 85d1821
refactor: remove triggers/required fields from custom checks
rnetser b94c158
refactor: consolidate custom check validation to single location
rnetser 7f30680
refactor: simplify closure and fix test fixtures
rnetser 63c6f03
resolve conflicts
rnetser 460095e
fix: remove undefined format_task_fields and invalid logger.step calls
rnetser c3512a9
Merge branch 'main' of github.com:myk-org/github-webhook-server into …
rnetser 4215081
refactor(custom-checks): simplify env vars and check run status handling
rnetser 6a6a1e5
fix(custom-checks): inherit parent environment for subprocess execution
rnetser b4ba235
fix(custom-checks): address CodeRabbit review comments
rnetser 5b5812a
fix(custom-checks): address CodeRabbit review comments (round 2)
rnetser 02e6252
fix(custom-checks): add duplicate name detection and improve typing
rnetser 7ed2baa
fix(tests): tighten return type annotations to satisfy ANN401
rnetser c548ebc
fix(tests): tighten get_value_side_effect return type
rnetser 3af1304
fix(tests): use dict[str, object] instead of dict[str, Any] in type a…
rnetser 8442fe6
Merge branch 'main' of github.com:myk-org/github-webhook-server into …
rnetser 16f46a6
refactor: address PR #961 review comments
rnetser c96a569
feat: add mandatory option for custom check runs
rnetser a9eaa8f
refactor: remove env field support from custom check runs
rnetser 794ef2a
Merge branch 'main' of github.com:myk-org/github-webhook-server into …
rnetser 1a37f6c
refactor: replace specific check run methods with generic pattern
rnetser 1f9d61a
refactor: unify custom and built-in check execution into single run_c…
rnetser b27635e
fix: address CodeRabbit review comments for custom check runs
rnetser 33818a4
fix: remove duplicate auto_verified_and_merged_users definition
rnetser 29f67d8
fix: remove unnecessary custom: prefix stripping from /retest handler
rnetser 3aa09bc
refactor: remove redundant comments from handler files
rnetser b53dd88
fix: add type guards and improve test assertions for custom check val…
rnetser 162b93b
fix: add type guards for custom check validation and improve test typing
rnetser 7bf86bc
fix: improve type safety, graceful timeout handling, and test consist…
rnetser cd650fc
refactor: address PR #961 review comments
rnetser e025430
fix(runner): track scheduled tests for accurate retest error logging
rnetser 3498fab
docs: add security warning for custom-check-runs feature
rnetser a05ed3b
fix(runner): wrap custom check commands in shell for env var support
rnetser f877603
Merge branch 'main' of github.com:myk-org/github-webhook-server into …
rnetser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.