Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds sanitizer support to the xcodebuild action, enabling Thread Sanitizer (TSan) and Address Sanitizer (ASan) for detecting bugs during testing. The implementation allows users to specify either "thread" or "address" sanitizer through a new input parameter.
- Added sanitizer input parameter with support for thread and address sanitizers
- Updated xcodebuild command generation to include appropriate sanitizer flags
- Added comprehensive documentation and CI verification
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/index.ts | Added sanitizer input handling and xcodebuild flag generation for test/build-for-testing actions |
| action.yml | Added new sanitizer input parameter with detailed description of options |
| README.md | Added sanitizer documentation with usage examples for both TSan and ASan |
| .github/workflows/checks.yml | Added CI job to verify sanitizer functionality on macOS |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
@mxcl Added the dist that weren't there and caused the failures. |
Contributor
Author
|
Thank you @mxcl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for Thread Sanitizer (TSan) and Address Sanitizer (ASan) to help detect bugs during testing.
Changes
Usage
Note: Only one sanitizer can be enabled at a time.