Fix crashes and cleanup warnings #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids having an arbitrarily sized, big array on the stack. Also avoids an extra copy.
Avoids stack overflows. The compressed sample data is appended to a vector, avoiding constraining the size arbitrarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm familiar with C but not with C++. I massaged the code (with some help from valgrind and asan) until it no longer crashed compressing the soundfonts I had, which are:
I also cleaned up some warnings which appeared with
-Wall. You might want to cherry-pick one or more of the individual commits even if you reject the PR as a whole.