Stave labelling improvements#32457
Conversation
mike-spa
force-pushed
the
staveLabellingImprovements
branch
from
4f8cd7a to
72f24db
Compare
mike-spa
force-pushed
the
staveLabellingImprovements
branch
from
fd8be7d to
0d16912
Compare
| @@ -52,6 +55,9 @@ class InstrumentName final : public TextBase | |||
| void setInstrumentNameType(InstrumentNameType v); | |||
| void setInstrumentNameType(const String& s); | |||
There was a problem hiding this comment.
This looks like it's unused along with instrumentNameTypeName
| switch (el->type()) { | ||
| case ElementType::INSTRUMENT_NAME: | ||
| m_staves[el->staffIdx()]->instrumentName = nullptr; | ||
| // TODO: I'm pretty sure that this gets leadked. Needs fixing. |
There was a problem hiding this comment.
Yes - along with all other generated items!
| void EditStaffType::setFromDlg() | ||
| { | ||
| staffType.setName(name->text()); | ||
| staffType.setStaffTypeName(name->text()); |
There was a problem hiding this comment.
name is read only, so I think we can get rid of StaffTypeName::setStaffTypeName
| m_group = sg; | ||
| m_xmlName = xml; | ||
| m_name = name; | ||
| m_staffTypeName = name; |
There was a problem hiding this comment.
Further to my comment about making this readonly above, we should get rid of m_staffTypeName and m_xmlName, and implement TConv methods for the StaffTypes enum.
Bit of a distraction sorry, but always looking for ways to clean up this file!
There was a problem hiding this comment.
Agree 100% but let's do it separately
| void ChangeStaffType::flip(EditData*) | ||
| { | ||
| StaffType oldStaffType = *staff->staffType(Fraction(0, 1)); // TODO | ||
| StaffType oldStaffType = *staff->staffType(tick); // TODO |
There was a problem hiding this comment.
This is probably what the todo is referring to? Even if not, I don't know what it means so let's get rid
2 participants
No description provided.