Skip to content

fix #16842: alignment of winged repeat barline#32436

Merged
miiizen merged 1 commit intomusescore:masterfrom
futamapapa:16842-fix-repeatbarlinetips
Mar 6, 2026
Merged

fix #16842: alignment of winged repeat barline#32436
miiizen merged 1 commit intomusescore:masterfrom
futamapapa:16842-fix-repeatbarlinetips

Conversation

@futamapapa
Copy link
Copy Markdown
Contributor

Resolves: #16842

The root cause of the issue is that, for end repeat barlines, the repeat dot is used as the origin of the X coordinate, causing the bounding box to extend beyond the right edge of the barline.

I updated the calculation of the horizontal offset w1 for reversedBracket, which was previously fixed to 0, so that it is computed correctly when a wing is present.

In TLayout::layoutBarLine:
w1 is calculated as the difference between the width of a repeat barline without wings (w) and the width of the wing (font->width(SymId::reversedBracketTop, magS)).

In TLayout::layoutBarLine2:
Since bbox.x() already accounts for this offset, w1 is obtained as the difference from item->symBbox(SymId::reversedBracketTop).x(), which does not account for the offset.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)
20260301_MuseScore_WingedRepeatBarline 20260301_MuseScore_WingedRepeatBarline_CheckResult

@miiizen miiizen merged commit 07f5dab into musescore:master Mar 6, 2026
12 checks passed
@Jojo-Schmitz
Copy link
Copy Markdown
Contributor

wanted for 4.7?

@miiizen
Copy link
Copy Markdown
Contributor

miiizen commented Mar 6, 2026

No thanks, we're limiting PRs to regressions & what's already in the project at this point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Winged repeats do not align at the end of the system.

3 participants