Fix #31353: macOS Trackpad 'Tap to Click' causes stuck notes on Virtual Piano in MuseScore #31574
+23
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
approved these changes
Dec 24, 2025
+ faster insertion time + no need for complex less operators
RomanPudashkin
force-pushed
the
midi_events_order_fix
branch
from
9981ba9 to
2280822
Compare
Contributor
|
Issue with MS Basic (note continues playing infinitely) is FIXED. But there is still no sound when tap to click when using MuseSound (mac only). This issue doesn't occur in 4.5.2 Screen.Recording.2026-01-02.at.18.53.34.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #31353
MIDI NoteOff < NoteOn. Thus, if we receive them in the order on -> off simultaneously (quick key press), their order later changes to off -> on, which causes the note to hang