Add missing mensural prolations to time signature properties dialog #31557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mensuralProlation6` and `mensuralProlation9` were missing for seemingly no good reason. Also update the comments to match the SMuFL spec (don’t know if that makes them more accurate or not though) Resolves: #31553
2 tasks
Contributor
|
Wouldn't we also need to make the symId names translatable? The missing ones were in, but commented out before 98464fd, which removed them. There are missing counterparts in src/framework/ui/view/musicalsymbolcodes.h (see your #9741) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mensuralProlation6andmensuralProlation9were missing for seemingly no good reason.Also update the comments to match the SMuFL spec (don’t know if that makes them more accurate or not though)
Resolves: #31553