-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix Shift+click selection between chord symbols and Roman numerals (Fixes #31410) #31547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Shift+click selection between chord symbols and Roman numerals (Fixes #31410) #31547
Conversation
XiaoMigros
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems easier to add a subtype property to harmony elements (equal to harmonytype). That reduces special logic and would allow for special selections in the select/more menu. See #20850 for an example of how to implement it (and what other methods are needed).
5031a7e to
43cf0f7
Compare
|
Thanks for the suggestion! 2025-12-24.143938.mp4 |
|
Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved |
Resolves: #31410
This PR fixes the selection behavior where chord symbols and Roman numeral analysis were selected together when using click / Shift+click.
After this change, chord symbols, Roman numerals, and Nashville notation are treated as separate selectable elements for default click and Shift+click operations, while keeping the existing selection model otherwise unchanged.
Demo
2025-12-20.161633.mp4