Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the isVehicleOnGround function similarly to how #4317 fixed IsPedOnGround.
The current logic is very primitive. It simply checks the distance from the bottom of the bounding box to the ground. That’s why if a vehicle is, for example, lying on its roof, it returns false. It can also return false on slopes, and for a Monster Truck it always returns false, because its wheels aren’t included in the bounding box, which ends at the model’s edge.

The fixed isVehicleOnGround function now first does a simple check to see if any wheel is touching the ground. If so, the vehicle is considered on the ground. If not, it performs a basic OOB check and measures the distance to the ground. During testing, I never received a false negative.
Motivation
Fixed #471 and #2093
Test plan
Tested.
Checklist