Bump LunaSVG to 3.5.0 #4615
Open
Bump LunaSVG to 3.5.0 #4615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lua API: svgRegisterFont(string fontFamily, string path) svgUnregisterFont(string fontFamily)
MegadreamsBE
added
enhancement
Contributor
|
|
Member
|
Since these are conceptually different changes, please could we move the custom resource font support to a separate pull request? (you could maybe, optionally, stack it on top of this pull request) |
This reverts commit 969dfec.
Lpsd
changed the title
Member
Author
qaisjp
approved these changes
Jan 8, 2026
Member
qaisjp
left a comment
qaisjp
left a comment
There was a problem hiding this comment.
LGTM.
Maybe we should wait until 1.7 releases before merging, since (presumably) 1.7 will release in the next couple of weeks? What do you think?
Member
Author
|
sounds fine, there is nothing urgent here as far as I'm aware. thanks! |
qaisjp
approved these changes
Jan 8, 2026
Member
qaisjp
left a comment
qaisjp
left a comment
There was a problem hiding this comment.
Re-approving since I wasn't in the blue contributors team (just added myself now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps LunaSVG from 3.2.0 to 3.5.0. See releases for LunaSVG
Additional PR for custom font support #4620