Gate diagnostics snapshot on flag OR widget presence and add tests #715
+57
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Dashboard.diagnostics_snapshot()calls while still providing diagnostics to widgets when present by gating snapshotting on either the dev flag or a diagnostics widget being configured.Description
src/gui/mod.rsto computediagnosticsasSome(self.dashboard.diagnostics_snapshot())whenself.show_dashboard_diagnostics || has_diagnostics_widgetis true, andNoneotherwise.src/gui/mod.rs:diagnostics_context_includes_snapshot_when_widget_presentanddiagnostics_context_omits_snapshot_when_disabled_and_missing_widgetto cover both inclusion and exclusion cases.src/gui/mod.rsonly and reuses the existinghas_diagnostics_widget()helper andDashboard.diagnostics_snapshot()accessor.Testing
diagnostics_context_includes_snapshot_when_widget_presentanddiagnostics_context_omits_snapshot_when_disabled_and_missing_widgetinsrc/gui/mod.rs.Codex Task