Enable diagnostics widget when present in dashboard layout #714
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
show_dashboard_diagnosticsflag is false.Description
has_diagnostics_widgethelper and computeshow_diagnostics_widget = self.show_dashboard_diagnostics || has_diagnostics_widgetwhen constructingDashboardContext, and only collect a diagnostics snapshot when that combined flag is true.Dashboard::ui(so diagnostics rendering can still be skipped when the widget is genuinely absent) and add a unit test that builds a minimal dashboard with a diagnostics slot to validate the computed flag.Testing
diagnostics_widget_layout_enables_context_flaginsrc/gui/mod.rswhich asserts the computed flag is enabled when a diagnostics slot is present, and no automated test suite was executed as part of this change.Codex Task