Conversation
multi-io
reviewed
Jan 22, 2019
| class <<Kernel | ||
| alias_method :old_warn, :warn | ||
| def warn(*args) | ||
| if RUBY_VERSION >= '2.5.0' # REXML uses additional hash parameters in ruby 2.5 and onwards |
Owner
There was a problem hiding this comment.
Do we need the if-else here? def warn(msg, **options) should be fully compatible with pre-2.5 REXML even if it doesn't pass any options, afaics.
Owner
|
About the gemspec file -- why do people want to add this? Doesn't anybody like my gem specification in the Rakefile? I was mighty proud of it back then I remember :) Right now you're duplicating the Rakefile FILES_* variables in the gemspec file. I'd be OK with having a gemspec file and loading it from the Rakefile so we avoid this duplication. Alternatively, just remove the gemspec file from the PR and we could refactor this later separately. |
Owner
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.