[button][fab][menu item][list item button] Remove duplicated className entries

[silviuaavram]

• I have followed (at least) the PR section of the contributing guide.

Fixes #48189.

Do not send classes.root to the ButtonBase classes as it will end up in duplicated classes. Affected components:

• Button
• FAB
• MenuItem
• ListItemButton

[mui-bot]

Netlify deploy preview

https://deploy-preview-48213--material-ui.netlify.app/

Bundle size report

Bundle	Parsed size	Gzip size
@mui/material	🔺+64B(+0.01%)	🔺+29B(+0.02%)
@mui/lab	0B(0.00%)	0B(0.00%)
@mui/system	0B(0.00%)	0B(0.00%)
@mui/utils	0B(0.00%)	0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against aaffd00

[Copilot]

Pull request overview

This PR fixes duplicated CSS class entries on the Material UI Button root element by avoiding passing the same utility classes through both className and the classes prop path (via ButtonBase).

Changes:

• Remove classes.root from the className passed to ButtonRoot, relying on the existing classes={classes} forwarding to apply utility classes once.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[mnajdova]

I think we should omit classes.root when we propagate the classes prop instead. We should do that on all components using ButtonBase.

What I meant was doing this:

    <ButtonRoot
      ownerState={ownerState}
      className={clsx(contextProps.className, className, classes.root, positionClassName)}
      component={component}
      disabled={disabled || loading}
      focusRipple={!disableFocusRipple}
      focusVisibleClassName={clsx(classes.focusVisible, focusVisibleClassName)}
      ref={ref}
      internalNativeButton
      type={type}
      id={loading ? loadingId : idProp}
      {...other}
      // classes.root is already propagated in the className prop
      classes={{...classes, root: {}}}
    >

[ZeeshanTamboli]

I guess it's a regression since #25072. The issue is also present in v5: https://v5.mui.com/material-ui/react-button/.

[ZeeshanTamboli]

IMO, we should also cherry-pick this to v7.

[github-actions]

Cherry-pick PRs will be created targeting branches: v7.x