You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixed a bug where inline filtering stopped working after selecting an item in single selection mode with a controlled open state. The root cause was that closeQuery was being set even in inline mode, which froze the filtering query. Since inline mode doesn't use a popup (and thus has no close animations), there's no need to preserve the query via closeQuery. The fix adds !inline guards in two locations where closeQuery is set for single mode, consistent with the existing logic for multiple mode.
Confidence Score: 5/5
This PR is safe to merge with no risks
The fix is targeted, logical, and follows existing patterns in the codebase (multiple mode already had similar inline checks). The test case comprehensively validates the fix, and the change is minimal with clear intent.
No files require special attention
Important Files Changed
Filename
Overview
packages/react/src/combobox/root/AriaCombobox.tsx
Added !inline guards to prevent closeQuery from being set in inline mode, fixing filtering after selection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3976