Skip to content

[combobox] Fix inline filtering after selection in single mode#3978

Merged
atomiks merged 2 commits intomui:masterfrom
atomiks:codex/issue-3976-inline-filtering
Feb 6, 2026
Merged

[combobox] Fix inline filtering after selection in single mode#3978
atomiks merged 2 commits intomui:masterfrom
atomiks:codex/issue-3976-inline-filtering

Conversation

@atomiks
Copy link
Copy Markdown
Contributor

@atomiks atomiks commented Feb 5, 2026

Fixes #3976

@atomiks atomiks added type: bug It doesn't behave as expected. component: combobox Changes related to the combobox component. labels Feb 5, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 5, 2026

commit: da72090

@mui-bot
Copy link
Copy Markdown

mui-bot commented Feb 5, 2026

Bundle size report

Bundle Parsed size Gzip size
@base-ui/react 🔺+9B(0.00%) 🔺+4B(0.00%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 5, 2026

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit da72090
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6985cb9dffcc7d00081a01c9
😎 Deploy Preview https://deploy-preview-3978--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks marked this pull request as ready for review February 5, 2026 09:08
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Feb 5, 2026

Greptile Overview

Greptile Summary

Fixed a bug where inline filtering stopped working after selecting an item in single selection mode with a controlled open state. The root cause was that closeQuery was being set even in inline mode, which froze the filtering query. Since inline mode doesn't use a popup (and thus has no close animations), there's no need to preserve the query via closeQuery. The fix adds !inline guards in two locations where closeQuery is set for single mode, consistent with the existing logic for multiple mode.

Confidence Score: 5/5

  • This PR is safe to merge with no risks
  • The fix is targeted, logical, and follows existing patterns in the codebase (multiple mode already had similar inline checks). The test case comprehensively validates the fix, and the change is minimal with clear intent.
  • No files require special attention

Important Files Changed

Filename Overview
packages/react/src/combobox/root/AriaCombobox.tsx Added !inline guards to prevent closeQuery from being set in inline mode, fixing filtering after selection
packages/react/src/combobox/root/ComboboxRoot.test.tsx Added test case to verify filtering remains responsive after selection in inline mode with controlled open state

Copy link
Copy Markdown
Member

@mj12albert mj12albert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atomiks atomiks merged commit 02e722e into mui:master Feb 6, 2026
23 checks passed
@atomiks atomiks deleted the codex/issue-3976-inline-filtering branch February 6, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: combobox Changes related to the combobox component. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[combobox] Inline single select combobox filter gets stuck after selection

3 participants