[field][avatar] Add transition attributes#3939
Conversation
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
a4eea65 to
1176edf
Compare
Greptile OverviewGreptile SummaryThis PR adds transition attributes support to Key Changes
The implementation follows established patterns in the codebase and includes proper test coverage. Confidence Score: 5/5
Important Files Changed
|
mj12albert
left a comment
There was a problem hiding this comment.
Transition support would be useful for Field.Validity as well (e.g. animating a validity status indicator/svg) though it's a bit different
also an experiments nit: could maybe just add transitions to existing experiments (e.g. for checkbox, field error) instead of making an all new one ~
Yeah, the issue is
I intentionally left off accordion, collapsible, and popups for this demo since they have their own, but checkbox/radio/avatar etc. don't so I just made a single demo for them all together |
|
Does it make sense to add transitionStatus to the state called by the children render fn? |
ac5dbb5 to
2581049
Compare
|
@mj12albert yeah it's possible to add as part of the argument passed so children can use it (added demo with it) The main issue is you can't unmount the children since there's no control over |
2581049 to
a0ff491
Compare
|
Please update the PR title and labels to include all components that have updates so the changelog can be generated correctly. |
Yeah the issue is that checkbox/radio were drive-by changes here, they'll need to be split into "bug fixes" when writing release notes @flaviendelangle |
|
There seems to be an issue with displaying avatar fallback after these changes (on v1.2.0). If I understood correctly, AvatarImage now shows while the image is loading this line, but AvatarFallback can also be shown at the same time in low network conditions when |
|
@wishyoudie thanks for the report, can you make a new issue with a reproduction? |
Closes #3921
Also fixes a bug where
<Checkbox.Indicator>and<Radio.Indicator>didn't allow exit animations whenkeepMounted=falsehttps://deploy-preview-3939--base-ui.netlify.app/experiments/transition-attrs