fix(acestep-cpp): resolve relative model paths in options#8993
Open
localai-bot wants to merge 2 commits intomudler:masterfrom
Open
fix(acestep-cpp): resolve relative model paths in options#8993localai-bot wants to merge 2 commits intomudler:masterfrom
localai-bot wants to merge 2 commits intomudler:masterfrom
Conversation
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The acestep-cpp backend was failing to load models because the model paths in options (text_encoder_model, dit_model, vae_model) were being passed to the C++ code without resolving their relative paths. When a user configures acestep-cpp-turbo-4b, the model paths are specified as relative paths like 'acestep-cpp/acestep-v15-turbo-Q8_0.gguf'. The backend was passing these paths directly to the C++ code without joining them with the model directory. This fix: 1. Gets the base directory from the ModelFile path 2. Resolves all relative paths in options to be absolute paths 3. Adds debug logging to show resolved paths for troubleshooting Fixes mudler#8991 Signed-off-by: localai-bot <localai-bot@users.noreply.github.com>
localai-bot
force-pushed
the
fix-acestep-cpp-model-loading-8991
branch
from
967bf41 to
02e54e2
Compare
Contributor
Author
|
I've added a DCO signoff to the commit to resolve the failing DCO check. The commit has been force-pushed to the branch. The CI should rerun and the DCO check should pass now. |
mudler
reviewed
Mar 13, 2026
Signed-off-by: Ettore Di Giacinto <mudler@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #8991
The acestep-cpp backend was failing to load models because the model paths in options (text_encoder_model, dit_model, vae_model) were being passed to the C++ code without resolving their relative paths.
Problem
When a user configures acestep-cpp-turbo-4b, the model paths are specified as relative paths like
acestep-cpp/acestep-v15-turbo-Q8_0.gguf. The backend was passing these paths directly to the C++ code without joining them with the model directory, resulting in the error:Solution
This fix:
filepath.Join()Testing
The fix follows the same pattern used in other backends (e.g., llama.cpp backend) for resolving relative paths.
Fixes #8991