Fixing status typo and adding option to use LVPM. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccfries
reviewed
Aug 23, 2017
|
|
||
| if FLAGS.status: | ||
| print "Serialno : %d\n" % mon.getSerialNumber(); | ||
| mon.fillAllStatusPacket() |
Contributor
There was a problem hiding this comment.
So,
I accidentally committed this work-in-progress :)
I did add fillAllStatusPacket (in only HVPM) in another pull request, but I had some questions as to what was the intention of it, or if my additions just belonged in fillStatusPacket.
Collaborator
There was a problem hiding this comment.
Leaving this open for the moment. The intention of fillStatusPacket() is what you're suspecting it was, to fill in every applicable value from the firmware. Since I removed fillAllStatusPacket() from HVPM when merging them, your code will be break slightly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change corrects a typo with status calls, and allows the user to switch to the LVPM interface.