feature: Updating ssh protocol to support disconnect message and language in packet#1455
Open
Luwdo wants to merge 1 commit intomscdex:masterfrom
Open
feature: Updating ssh protocol to support disconnect message and language in packet#1455Luwdo wants to merge 1 commit intomscdex:masterfrom
Luwdo wants to merge 1 commit intomscdex:masterfrom
Conversation
Author
|
This is still an issue that is hiding ssh client visibility of messages concerning the reason why a connection was rejected. |
Owner
|
This needs a test. |
Author
I can work on getting a test added to my PR. |
ProTogen11
approved these changes
Jul 31, 2025
ProTogen11
previously approved these changes
Jul 31, 2025
…er end() Update Protocol.disconnect() to write the description message and language tag fields per RFC 4253 §11.1 instead of zero-filling them. Expose the new parameters through Client.end() and the server-side Connection.end() so callers can specify a disconnect reason code, a human-readable message, and an optional language tag. Add test for server disconnect with custom reason and message.
Luwdo
force-pushed
the
ssh-connection-disconnect-message-option
branch
from
432ea13 to
747ffa1
Compare
Author
|
@mscdex this is updated now with tests |
Luwdo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows more fine grained control of the disconnect message packet. Allowing custom authentication implementations to communicate to clients the reason for connection failure.
A common pattern that openssh implements is an authentication failure limit. Resulting in the following message:
ssh2 js can implement this but there was no way to pass back a human readable message or change the reason to PROTOCOL_ERROR: 2 which is most appropriate for a "Too many authentication failures" message.
Fall back is set to reason: BY_APPLICATION so those who do not implement custom authentication exit patterns won't be affected.