feat: Add Device Identifiers to Attributes and Fix Mapping#42
Closed
BrandonStalnaker wants to merge 4 commits intomainfrom
Closed
feat: Add Device Identifiers to Attributes and Fix Mapping#42BrandonStalnaker wants to merge 4 commits intomainfrom
BrandonStalnaker wants to merge 4 commits intomainfrom
Conversation
f9a2b5b to
8aa4747
Compare
|
let's not ship this |
Collaborator
Author
|
@samdozor I have quite a few other improvements included in this PR. I'm assuming your comment is in reference to the code sdding MPID, IDFA, and IDFV to the attributes being passed to the Rokt SDK? If you could confirm that I'd like to remove that code and just rename the commit on merge. |
Collaborator
Author
|
Important parts moved to b24271e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Device Identifiers
Configuration Access Fix
Code Quality Improvements
Testing Plan
Tests will fail until new binary of core sdk is released
Added 6 new unit tests covering:
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)