feat: Add Rokt close implementation and init callback#49
Merged
jamesnrokt merged 1 commit intodevelopmentfrom Jul 15, 2025
Merged
feat: Add Rokt close implementation and init callback#49jamesnrokt merged 1 commit intodevelopmentfrom
jamesnrokt merged 1 commit intodevelopmentfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
Maps mParticle’s RoktKit integration to the Rokt SDK’s close and init callbacks.
- Adds an initialization callback to log whether Rokt setup succeeded.
- Implements
close()to forward the close call to the Rokt SDK. - Cleans up imports and suppresses unused warnings on the class.
Comments suppressed due to low confidence (2)
src/main/kotlin/com/mparticle/kits/RoktKit.kt:274
- Add unit or integration tests to verify that
close()correctly invokesRokt.close()and that any related callbacks or resource cleanup behave as expected.
override fun close() {
src/main/kotlin/com/mparticle/kits/RoktKit.kt:274
- If the base
KitIntegrationclass has cleanup logic in its ownclose()method, you may need to callsuper.close()here to ensure proper teardown of shared resources.
override fun close() {
thomson-t
approved these changes
Jul 14, 2025
rmi22186
reviewed
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)