Skip to content

fix: Removed Branch.disableDeviceIDFetch(!MParticle.isAndroidIdEnabled()) from onKitCreate#119

Merged
Mansi-mParticle merged 1 commit intomparticle-integrations:mainfrom
bboothe-branch:fix/bboothe-branch/remove-disableDeviceIDFetch
Jan 22, 2026
Merged

fix: Removed Branch.disableDeviceIDFetch(!MParticle.isAndroidIdEnabled()) from onKitCreate#119
Mansi-mParticle merged 1 commit intomparticle-integrations:mainfrom
bboothe-branch:fix/bboothe-branch/remove-disableDeviceIDFetch

Conversation

@bboothe-branch
Copy link
Copy Markdown
Contributor

Teams were concerned about setting debug = true automatically. In removing this code, we are giving teams the option of setting debug = true down the line instead of on initialization.

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Branch.disableDeviceIDFetch(!MParticle.isAndroidIdEnabled()) has been removed from the onKitCreate function of the BranchMetricsKit.kt file.
  • Previously, this line was setting a branch SDK boolean received on installs and opens named "debug" to "true" if the androidID was disabled. This caused issue with reinstalls not being counted as the SDK was functioning in debug mode.

Testing Plan

  • This was tested locally by adding this build to the mparticle testing app and performing an install and open and verifying the debug = false logs in the install output data.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@bboothe-branch
Copy link
Copy Markdown
Contributor Author

Closed old Pull Request here and opened this one to properly name branch to mParticle guidelines.

Hoping this change and bump is what's required for review.

@bboothe-branch
Copy link
Copy Markdown
Contributor Author

@Mansi-mParticle hello! I'm not sure if you're the one to ask but do you know best to check into this?

Copy link
Copy Markdown
Contributor

@Mansi-mParticle Mansi-mParticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mansi-mParticle Mansi-mParticle changed the base branch from development to main January 22, 2026 16:39
@Mansi-mParticle Mansi-mParticle merged commit d4a89fd into mparticle-integrations:main Jan 22, 2026
@bboothe-branch
Copy link
Copy Markdown
Contributor Author

Thank you both!!

@Mansi-mParticle
Copy link
Copy Markdown
Contributor

@bboothe-branch F.Y.I This change has been released in v5.76.0.

@bboothe-branch
Copy link
Copy Markdown
Contributor Author

Hi @Mansi-mParticle thank you for sending the version number over. PERFECT timing as I was coming here today to ask!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants