Skip to content

clippy: fix from_iter_instead_of_collect lint#2614

Merged
sylvestre merged 1 commit intomozilla:mainfrom
xtqqczze:clippy/from_iter_instead_of_collect
Mar 5, 2026
Merged

clippy: fix from_iter_instead_of_collect lint#2614
sylvestre merged 1 commit intomozilla:mainfrom
xtqqczze:clippy/from_iter_instead_of_collect

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.39%. Comparing base (3ad5944) to head (a19cd63).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/compiler/compiler.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2614      +/-   ##
==========================================
+ Coverage   72.38%   73.39%   +1.01%     
==========================================
  Files          68       68              
  Lines       37219    37219              
==========================================
+ Hits        26941    27318     +377     
+ Misses      10278     9901     -377     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xtqqczze xtqqczze marked this pull request as ready for review February 12, 2026 22:48
Copy link
Copy Markdown
Collaborator

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you for your PR, while I understand the intent, I don't think it improves readability nor do I think the additional need for Iteratools is a net positive

@xtqqczze
Copy link
Copy Markdown
Contributor Author

nor do I think the additional need for Iteratools is a net positive

We already use itertools here.

@sylvestre
Copy link
Copy Markdown
Collaborator

needs to be rebased

@xtqqczze xtqqczze force-pushed the clippy/from_iter_instead_of_collect branch from 604fa24 to a19cd63 Compare March 5, 2026 22:17
@sylvestre sylvestre merged commit 2b65ac8 into mozilla:main Mar 5, 2026
50 checks passed
@xtqqczze xtqqczze deleted the clippy/from_iter_instead_of_collect branch March 5, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants