Fix sibling selection logic and bbc-reader-bug test#1008
Open
Prasadzoman wants to merge 2 commits intomozilla:mainfrom
Open
Fix sibling selection logic and bbc-reader-bug test#1008Prasadzoman wants to merge 2 commits intomozilla:mainfrom
Prasadzoman wants to merge 2 commits intomozilla:mainfrom
Conversation
- Restore canonical Mozilla sibling scoring logic - Fix paragraph fallback thresholds - Update test fixtures to ensure consistent parsing across jsdom and JSDOMParser - Ensure excerpt comes from meta description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1005
This PR restores the canonical Mozilla sibling selection logic in _grabArticle
and fixes the bbc-reader-bug test case.
Changes:
Result:
All tests passing (1997/1997)
No regressions in existing test suite