-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Update image pattern in gulpfile to accommodate missing images #20554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
timvandermeij
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, with the comment addressed and the commits squashed into one (see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits).
|
Please fix the linting and squash the commits into one, with a good commit message (see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits if you're not familiar with how to do that). It looks like after that this should be good to merge. |
8bf19c5 to
d072be1
Compare
|
@timvandermeij Should be good to go now. It shows changes of another file because I merged the master into the patch? |
|
You can update your master branch and then rebase your branch. |
Thank you for bearing with me should be good to go now! |
|
Thank you for your contribution! |
Closes #20553