Skip to content

Conversation

@dgiessing
Copy link
Contributor

Closes #20553

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with the comment addressed and the commits squashed into one (see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits).

@timvandermeij
Copy link
Contributor

Please fix the linting and squash the commits into one, with a good commit message (see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits if you're not familiar with how to do that). It looks like after that this should be good to merge.

@dgiessing dgiessing force-pushed the patch-1 branch 2 times, most recently from 8bf19c5 to d072be1 Compare January 22, 2026 19:58
@dgiessing
Copy link
Contributor Author

@timvandermeij Should be good to go now. It shows changes of another file because I merged the master into the patch?

@calixteman
Copy link
Contributor

You can update your master branch and then rebase your branch.

@dgiessing
Copy link
Contributor Author

You can update your master branch and then rebase your branch.

Thank you for bearing with me should be good to go now!

@timvandermeij timvandermeij merged commit bfa44af into mozilla:master Jan 23, 2026
10 checks passed
@timvandermeij
Copy link
Contributor

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Missing Images Referenced from CSS in pdfjs-dist 5.4.530

3 participants