Skip to content

Use CIDToGIDMap when the font is a type 2 with an OpenType font #20535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timvandermeij merged 1 commit into from
Dec 28, 2025
Merged

Use CIDToGIDMap when the font is a type 2 with an OpenType font #20535

timvandermeij merged 1 commit into from
Dec 28, 2025
+42 −30

Conversation

@calixteman
Copy link
Contributor

@calixteman calixteman commented Dec 25, 2025

It fixes #18062.

@calixteman
Copy link
Contributor Author

calixteman commented Dec 25, 2025

/botio test

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 25, 2025

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/4cb6a25f0bfae5a/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 25, 2025

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f22adb6f4a0c377/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 25, 2025

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/f22adb6f4a0c377/output.txt

Total script time: 40.97 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/f22adb6f4a0c377/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 25, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/4cb6a25f0bfae5a/output.txt

Total script time: 76.93 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/4cb6a25f0bfae5a/reftest-analyzer.html#web=eq.log

@calixteman calixteman marked this pull request as ready for review December 26, 2025 11:11
@calixteman
Copy link
Contributor Author

calixteman commented Dec 26, 2025

/botio test

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 26, 2025

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0d250089b740e8d/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 26, 2025

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/af8659a4926f898/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 26, 2025

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/0d250089b740e8d/output.txt

Total script time: 1.09 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.241.84.105:8877/0d250089b740e8d/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 26, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/af8659a4926f898/output.txt

Total script time: 2.95 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.193.163.58:8877/af8659a4926f898/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

calixteman commented Dec 26, 2025

/botio test

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 26, 2025

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f587c5eb58bf45e/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 26, 2025

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/18a3e15ed9ba627/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 26, 2025

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/f587c5eb58bf45e/output.txt

Total script time: 41.35 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/f587c5eb58bf45e/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 26, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/18a3e15ed9ba627/output.txt

Total script time: 76.99 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/18a3e15ed9ba627/reftest-analyzer.html#web=eq.log

This was linked to issues Dec 27, 2025
Certain korean charachters displaying as chinese charachters #16068
Closed
pdf files cannot be previewed #16098
Closed
Part of the content is not displayed #13850
Closed
[Bug]: Missing Chinese character and part of number; #19089
Closed
Some text disappeared in this PDF. #13309
Closed
timvandermeij
timvandermeij approved these changes Dec 28, 2025
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with a rebase. Thank you for fixing this!

@calixteman
Copy link
Contributor Author

calixteman commented Dec 28, 2025

/botio test

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 28, 2025

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9c2ec75bd71e675/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 28, 2025

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/49d9b76a2b7f94d/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 28, 2025

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/9c2ec75bd71e675/output.txt

Total script time: 40.90 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/9c2ec75bd71e675/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 28, 2025

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/49d9b76a2b7f94d/output.txt

Total script time: 80.01 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/49d9b76a2b7f94d/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit 50cc4ad into mozilla:master Dec 28, 2025
10 checks passed
@timvandermeij
Copy link
Contributor

timvandermeij commented Dec 28, 2025

/botio makeref

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 28, 2025

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9d1fc27a78fcab3/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 28, 2025

From: Bot.io (Windows)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/58c03b41570a931/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 28, 2025

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/9d1fc27a78fcab3/output.txt

Total script time: 18.78 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Dec 28, 2025

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/58c03b41570a931/output.txt

Total script time: 32.81 mins

  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees

No one assigned

Labels

font-conversion

Projects

None yet

Milestone

No milestone

3 participants

@calixteman @moz-tools-bot @timvandermeij