Use correct parameter and properly warn when clearing fails instead of silently dropping errors#3479
Open
badboy wants to merge 1 commit into
Open
Use correct parameter and properly warn when clearing fails instead of silently dropping errors#3479badboy wants to merge 1 commit into
badboy wants to merge 1 commit into
Conversation
…f silently dropping errors
chutten
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My change in the earlier PR was not entirely correct and made several tests fail (in the full change).
Hard to track down as we dropped the error on the floor. Now we're getting a warning for it.