Conversation
vbudhram
changed the title
4 tasks
dschom
approved these changes
Feb 11, 2026
vbudhram
force-pushed
the
FXA-12996
branch
5 times, most recently
from
7fdf8d6 to
ed46524
Compare
…references Remove the fxa-graphql-api package and all remaining GraphQL artifacts from fxa-settings now that it uses direct auth-client calls. Update l10n tests to use current translation keys from the upstream l10n repo.
vbudhram
commented
Feb 11, 2026
| ); | ||
|
|
||
| // en-GB uses British spellings: "authorised" and "cancelled" | ||
| assert.include(result, 'authorised'); |
Contributor
Author
There was a problem hiding this comment.
This was caused by changes in the fxa l10n repo, appears some text got removed. I've updated these tests to use strings that are avaiable but also cover the test case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: (issue number)
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.