docs: add desktop Feature Manifest reference, reorganize feature definition#795
Open
jaredlockhart wants to merge 5 commits intomainfrom
Open
docs: add desktop Feature Manifest reference, reorganize feature definition#795jaredlockhart wants to merge 5 commits intomainfrom
jaredlockhart wants to merge 5 commits intomainfrom
Conversation
…nition Because * The desktop FeatureManifest.yaml schema had no dedicated reference — only a brief example in feature-api.mdx * The generic feature-definition.md was a thin page that didn't clearly direct users to the right platform-specific docs * Engineers defining new desktop features had to piece together the schema from scattered sources This commit * Creates a comprehensive Desktop Feature Manifest Reference doc covering all feature-level properties (description, owner, hasExposure, isEarlyStartup, allowCoenrollment, applications, schema), all variable properties (type, fallbackPref, setPref, enum), a setPref vs fallbackPref comparison, and real-world examples * Adds the new doc to the sidebar under Desktop (first item) * Slims down the registration section in feature-api.mdx with a cross-link to the full reference * Rewrites feature-definition.md as a clear crossroads page pointing to Desktop manifest reference, FML spec, and Cirrus guide Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jaredlockhart
requested review from
freshstrangemusic,
mikewilli,
relud and
yashikakhurana
as code owners
Because * Reviewer requested wording improvements and additional details This commit * Updates intro paragraph wording per reviewer suggestion * Changes Searchfox URL to firefox-main in feature-api.mdx * Adds moz-src:// as an alternative URI scheme for schema validation * Expands "repo root" to "repository root" * Adds note about floats needing to be strings * Updates json type description to "stringified JSON if connected to a pref" * Removes redundant enum note already covered by the table * Simplifies feature definition intro sentence Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Because * The "as small as a single function or as complex as a whole page" wording provides helpful context for newcomers This commit * Reverts the intro sentence in feature-definition.md to its original form Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Because * The inline comments provide helpful context for each property right where developers see them This commit * Restores the original YAML comments in the feature registration example Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Because
* The original wording ("experimentation ecosystem", "experiment surfaces")
is the established terminology
This commit
* Restores the intro paragraph in feature-definition.md to its original form
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
freshstrangemusic
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creates a comprehensive desktop FeatureManifest.yaml reference doc and reorganizes the generic feature definition page.
New doc: Desktop Feature Manifest Reference (
docs/platform-guides/desktop/feature-manifest.md)description,owner,hasExposure/exposureDescription,isEarlyStartup,allowCoenrollment,applications,schematype,fallbackPref,setPref,enumsetPrefvsfallbackPrefcomparison table with behavior differencesReorganization:
feature-definition.mdrewritten as a crossroads page → Desktop manifest ref, FML spec, Cirrus guidefeature-api.mdxregistration section slimmed down with cross-link to full referenceFixes #794
🤖 Generated with Claude Code