Skip to content

Bug 2045161 - Do not opt-out of unenrolled enrollments#7399

Merged
freshstrangemusic merged 1 commit into
mainfrom
freshstrangemusic/push-kzopqpsmylsq
Jun 8, 2026
Merged

Bug 2045161 - Do not opt-out of unenrolled enrollments#7399
freshstrangemusic merged 1 commit into
mainfrom
freshstrangemusic/push-kzopqpsmylsq

Conversation

@freshstrangemusic

Copy link
Copy Markdown
Member

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@freshstrangemusic freshstrangemusic force-pushed the freshstrangemusic/push-kzopqpsmylsq branch from d61371f to 424ae14 Compare June 7, 2026 19:06
@freshstrangemusic freshstrangemusic force-pushed the freshstrangemusic/push-kzopqpsmylsq branch from 424ae14 to aa4c66c Compare June 8, 2026 14:04
@freshstrangemusic freshstrangemusic requested a review from jeddai June 8, 2026 14:05

@jeddai jeddai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question — do we not want to allow users to opt-out of non-enrolled experiments as a method of preventing themselves from ever being enrolled?

@jeddai jeddai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so as not to block this landing if it is needed (I'm on PTO tomorrow), but I hope a conversation about my last comment has occurred and if it has already then no worries, go ahead and land it.

@freshstrangemusic

Copy link
Copy Markdown
Member Author

Question — do we not want to allow users to opt-out of non-enrolled experiments as a method of preventing themselves from ever being enrolled?

The UI of our browsers doesnt currently allow for this. The studies ui only shows things that are enrolled and the secret settings menu will call opt-out only if youre already in the experiment.

This is also not something we do on desktop

@freshstrangemusic freshstrangemusic added this pull request to the merge queue Jun 8, 2026
Merged via the queue into main with commit d63f45d Jun 8, 2026
14 checks passed
@freshstrangemusic freshstrangemusic deleted the freshstrangemusic/push-kzopqpsmylsq branch June 8, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants