Skip to content

Conversation

@lougeniaC64
Copy link
Contributor

@lougeniaC64 lougeniaC64 commented Jan 8, 2026

Removed the remaining SwiftKeychainWrapper logic. This is mostly in the form of license info. As such, the merging of this PR is blocked by the merging of the iOS PR that actually removes the now obsolete library.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@lougeniaC64 lougeniaC64 changed the title Removed SwiftKeychainWrapper logic Remove SwiftKeychainWrapper logic Jan 8, 2026
@lougeniaC64 lougeniaC64 requested a review from skhamis January 8, 2026 19:40
@lougeniaC64 lougeniaC64 marked this pull request as ready for review January 8, 2026 19:40
@lougeniaC64 lougeniaC64 force-pushed the remove-mzkeychainwrapper branch from 36bdddb to 02f6a37 Compare January 8, 2026 19:48
@lougeniaC64 lougeniaC64 force-pushed the remove-mzkeychainwrapper branch from 02f6a37 to 340df96 Compare January 8, 2026 19:59
Copy link
Contributor

@skhamis skhamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants