upgrade uniffi to 0.31 #7140
Open
upgrade uniffi to 0.31 #7140
+319
−345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhammond
force-pushed
the
push-snkqnkstyuox
branch
3 times, most recently
from
f36114a to
4c30cc3
Compare
mhammond
force-pushed
the
push-snkqnkstyuox
branch
12 times, most recently
from
fff97cb to
1212ca0
Compare
mhammond
force-pushed
the
push-snkqnkstyuox
branch
from
1212ca0 to
73be1b2
Compare
bendk
approved these changes
Jan 14, 2026
Contributor
bendk
left a comment
bendk
left a comment
There was a problem hiding this comment.
Looks great, I just noticed one minor thing.
| use camino::Utf8PathBuf; | ||
| use clap::{Args, Parser, Subcommand, ValueEnum}; | ||
| use std::fmt; | ||
| // TODO: remove blanket import |
Member
Author
There was a problem hiding this comment.
Nit: leftover comment.
It's actually in the code this was cloned from :) https://github.com/mozilla/uniffi-rs/blob/aac453d53687e87b33094cf754bed9fb39f75960/uniffi/src/cli/uniffi_bindgen.rs#L8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.