Relax rules around add-on names containing Firefox/Mozilla#24504
Open
diox wants to merge 3 commits intomozilla:masterfrom
Open
Relax rules around add-on names containing Firefox/Mozilla#24504diox wants to merge 3 commits intomozilla:masterfrom
diox wants to merge 3 commits intomozilla:masterfrom
Conversation
Previously only "<something> for Firefox" was allowed, now the name only needs to end with "Firefox" provided that it's long enough.
eviljeff
approved these changes
Feb 26, 2026
Member
eviljeff
left a comment
eviljeff
left a comment
There was a problem hiding this comment.
I wonder how (well|badly) would this work with a RTL language string? (although the Mozilla/Firefox would still be LTR)
Comment on lines
+45
to
+52
| symbol_count >= 1 | ||
| # 'XXX for Mozilla' or 'XXX for Firefox' is allowed... | ||
| and not normalized_name.endswith(f' {symbol}') | ||
| ) | ||
| or ( | ||
| symbol_count >= 1 | ||
| # ...'XX for Firefox' is too short though | ||
| and len(variant) < len(symbol) + 6 |
Member
There was a problem hiding this comment.
kind of a nit
Suggested change
| symbol_count >= 1 | |
| # 'XXX for Mozilla' or 'XXX for Firefox' is allowed... | |
| and not normalized_name.endswith(f' {symbol}') | |
| ) | |
| or ( | |
| symbol_count >= 1 | |
| # ...'XX for Firefox' is too short though | |
| and len(variant) < len(symbol) + 6 | |
| symbol_count == 1 | |
| and ( | |
| # 'XXX for Mozilla' or 'XXX for Firefox' is allowed... | |
| not normalized_name.endswith(f' {symbol}') | |
| # ...'XX for Firefox' is too short though | |
| or len(variant) < len(symbol) + 6 | |
| ) |
Member
Author
|
For we have a NARC rule disallowing bidi override characters so RTL is probably messy anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously only " for Firefox" was allowed, now the name only needs to end with "Firefox" provided that it's long enough.
Fixes mozilla/addons#15977