chore(ci): use gh actions to build and deploy to GAR and ghcr #1976
Conversation
chenba
force-pushed
the
chore/gh-action-build-deploy-and-preview-STOR-412
branch
from
6459cd1 to
3840d69
Compare
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
17 similar comments
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
chenba
force-pushed
the
chore/gh-action-build-deploy-and-preview-STOR-412
branch
from
3840d69 to
ecbb6da
Compare
chenba
force-pushed
the
chore/gh-action-build-deploy-and-preview-STOR-412
branch
from
ecbb6da to
4feb90f
Compare
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
6 similar comments
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
15 similar comments
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
chenba
added
preview
|
Preview environment has been deployed. Preview URL: https://pr1976-sync.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
| packages: write | ||
| uses: mozilla-it/deploy-actions/.github/workflows/build-and-push.yml@1b87069d293273436a84dff04954a8950d3ff9ca # v6.1.0 | ||
| with: | ||
| image_name: syncstorage-rs |
There was a problem hiding this comment.
I didn't add a '-spanner' postfix here, but I'm not against it. afaict we only need to update a couple of values in webservices-infra if we do make the change.
There was a problem hiding this comment.
Exactly, I think the intention will be to flip that in webservices-infra when we push our next deploy if we've moved to using -spanner. Doesn't hurt to leave it as is for now. I intentionally kept the GAR one without the postfix, like you are doing here, specifically so that we'd not have to depend on an infra change were we to need to deploy/sync with argo.
pjenvey
left a comment
pjenvey
left a comment
There was a problem hiding this comment.
A couple maybe downsides to this change:
- We'd be now building the final docker image twice (until we migrate more of the circleci workflow to actions) -- I believe the github actions run parallel with circleci's run? If so, then at least it's probably not necessarily adding any extra build time
- Publishing to GAR would always occur regardless of any tests failing in circleci
Which is probably ok since it's restricted to only master/tag builds. Maybe we should move more to github actions sooner rather than later.
|
I'm also going to note that we get a lot of noise on the PRs here with the action, noting that we have 145 comments on this PR alone. Perhaps there's a way to reduce that noise with the preview build notifications. Additionally, can we implement the checks being contingent on test results from CI? I know in the future we may move our whole deployment workflow to actions, but if we're passing back and forth between the two, that makes it tricky... I'd have to look more into if we can use signals from CI to affect the action, in the case of waiting for tests to pass. |
Yes.
I did briefly thought about triggering the github action only when the circleci workflow is successful, but then I remembered that our PRs require the branch to be up to date before merging, so I think we can rely on the PR's test results. |
With this patch we move to Github Actions for building and publish container images to GAR. Additionally we publish those images to ghcr. (At the moment the ghcr images are private due to some org level settings.)
DockerHub pushes will remain in CircleCI at the moment, since a) https://github.com/mozilla-it/deploy-actions does not support DockerHub, and b) we should consider removing DockerHub support(?).
Closes STOR-412