Add support for python 3.14 #744
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not too fond of reinventing the wheel but we only have one use of this and I don't feel like adding yet another dependency for something that's 20 lines of code... This is necessary to get scriptworker to work with python3.14
This fixes python 3.14 compatibility. `get_event_loop` used to create an event loop if there wasn't any but 3.14 changed that behavior so we have to explicitely create one now
There's no `0.7.9-python3.14-bookworm-slim` image but there is a `0.9.16-python3.14-bookworm-slim` one.
ahal
approved these changes
Dec 19, 2025
| import logging | ||
| import re | ||
|
|
||
| from aiomemoizettl import memoize_ttl |
jcristau
reviewed
Dec 23, 2025
| _BRANCH_COMMITS_CACHE_TTL_IN_SECONDS = 10 * 60 # 10 minutes | ||
| _fetch_github_branch_commits_data = memoize_ttl(_fetch_github_branch_commits_data_helper, get_ttl=lambda _: _BRANCH_COMMITS_CACHE_TTL_IN_SECONDS) | ||
| async def _fetch_github_branch_commits_data(context, repo_html_url, revision): | ||
| cache_key = (id(context), repo_html_url, revision) |
Contributor
There was a problem hiding this comment.
Per the previous comment we don't actually want the context in here? Probably safer to keep it at least for this commit, but might still warrant a comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept
_fetch_github_branch_commits_databecause the solution in #731 isn't working well with forks.Supersedes #731
Fixes #729