fix: review that CLOBBER file is in diff in merge day tests #1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcristau
reviewed
Jun 20, 2025
landoscript/tests/test_merge_day.py
Outdated
| initial_values, | ||
| expected_bumps, | ||
| {"CLOBBER": "Merge day clobber 2025-03-03"}, | ||
| {"CLOBBER": "Merge day clobber 2025-06-1"}, |
Contributor
There was a problem hiding this comment.
shouldn't that be 2025-06-10?
Contributor
Author
There was a problem hiding this comment.
yes, sigh...and now I get to figure out why the test didn't fail....(other tests did when I messed with the date..)
Contributor
Author
There was a problem hiding this comment.
ah; it's because this substring match still works which is unfortunate...
This is something I noticed was missing while reviewing the final form of mozilla-releng#1231.
bhearsum
force-pushed
the
push-przmuolkwool
branch
from
d5e91e9 to
e07f873
Compare
jcristau
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I noticed was missing while reviewing the final form of #1231.