feat: add transforms for cross trust domain integration tests #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahal
force-pushed
the
ahal/push-mrxknpqqztll
branch
3 times, most recently
from
f460699 to
b8d7c8e
Compare
ahal
force-pushed
the
ahal/push-mrxknpqqztll
branch
5 times, most recently
from
d4a7217 to
3bffe77
Compare
ahal
force-pushed
the
ahal/push-mrxknpqqztll
branch
from
3bffe77 to
cb71c85
Compare
ahal
force-pushed
the
ahal/push-mrxknpqqztll
branch
4 times, most recently
from
e2a3180 to
44fdfa7
Compare
bhearsum
approved these changes
Jul 14, 2025
Contributor
bhearsum
left a comment
bhearsum
left a comment
There was a problem hiding this comment.
Looks good overall! Some nice simplification in here compared to the fxci-config code as well. I would prefer to see the except handling comment addressed before it merges, but it's not absolutely necessary. The schema obviously needs to be fixed though!
| task_defs = get_target_defs({}, {"task": {"metadata": {"name": "task-c"}}}) | ||
| expected = get_expected(prefix, *task_defs) | ||
|
|
||
| counter = count() |
Contributor
There was a problem hiding this comment.
TIL itertools.count - nice trick.
ahal
force-pushed
the
ahal/push-mrxknpqqztll
branch
from
44fdfa7 to
df19ded
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.