Skip to content

Replace deprecated ActivityTestRule with ActivityScenario#4177

Merged
jonalmeida merged 2 commits intomasterfrom
test-cleanups
Mar 23, 2026
Merged

Replace deprecated ActivityTestRule with ActivityScenario#4177
jonalmeida merged 2 commits intomasterfrom
test-cleanups

Conversation

@rvandermeulen
Copy link
Copy Markdown
Contributor

  • Rewrite BrowserActivityTestRule using ExternalResource + ActivityScenario.launch()
  • Update CustomTabsTest to launch IntentReceiverActivity inline via ActivityScenario
  • Declare androidx.test:core as a direct androidTestImplementation dependency

- Rewrite BrowserActivityTestRule using ExternalResource + ActivityScenario.launch()
- Update CustomTabsTest to launch IntentReceiverActivity inline via ActivityScenario
- Declare androidx.test:core as a direct androidTestImplementation dependency
@jonalmeida
Copy link
Copy Markdown
Collaborator

I'd like @AaronMT to take a look at this. I have little opinion here atm.

@jonalmeida jonalmeida removed their request for review March 17, 2026 21:06
Copy link
Copy Markdown
Contributor

@AaronMT AaronMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean to me

@rvandermeulen rvandermeulen added the needs landing Auto lands approved and green PRs. label Mar 23, 2026
@mergify mergify bot added the queued label Mar 23, 2026
@mergify
Copy link
Copy Markdown

mergify bot commented Mar 23, 2026

Merge Queue Status

  • Entered queue2026-03-23 18:37 UTC · Rule: default
  • Checks passed · in-place
  • Merged2026-03-23 19:09 UTC · at abd6aae121f2f77dfcd27109f8c3bd7341687351

This pull request spent 31 minutes 40 seconds in the queue, including 31 minutes 16 seconds running CI.

Required conditions to merge
  • status-success=pr-complete

@jonalmeida jonalmeida merged commit ec4cde9 into master Mar 23, 2026
15 checks passed
@jonalmeida jonalmeida deleted the test-cleanups branch March 23, 2026 19:09
@mergify mergify bot removed the queued label Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs landing Auto lands approved and green PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants