Refactor pagination to preserve request parameters #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pagination logic was setting
params = Noneafter the first page, relying on GitHub's Link header URL to contain all query parameters. This is fragile and makes the code harder to maintain.Changes
urllib.parseto extract only thepagevalue from the Link header URLpageparameter instead of replacing the entire params objectBefore
After
This maintains the original request parameters (state, per_page, sort, direction) across all pages and prevents infinite loops from malformed pagination URLs.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.