Fix: SPA navigation (once again)#3554
Merged
mattgperry merged 2 commits intomotiondivision:mainfrom Mar 3, 2026
Merged
Conversation
Contributor
Author
|
test-react-19 🤷 |
Collaborator
|
Thanks for your work on this! |
codeCraft-Ritik
left a comment
codeCraft-Ritik
left a comment
There was a problem hiding this comment.
Nice approach — the logic flows well and is readable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up on #3516
Unfortunately #3543 was on the wrong track, nothing improved with client side navigations. Pruning worked correctly there, but didn't fix the animation skip shown in my original PR.
I also tried to simplify the overall code, made the test more accurate, and did some further debugging that made me find a leak where the flat tree nodes were growing in size (since pruning was scoped to the members of add() only).
Here the animations are triggered correctly, pruning is basically the same + unmount()
I tried setting the new test runs to 100 and checking the js heap size.
Now
Without unmount (pruning only stack.ts' members)
