feat: adds combinePages option to diff per-page#98
Open
EvHaus wants to merge 1 commit intomoshensky:masterfrom
Open
feat: adds combinePages option to diff per-page#98EvHaus wants to merge 1 commit intomoshensky:masterfrom
EvHaus wants to merge 1 commit intomoshensky:masterfrom
Conversation
EvHaus
commented
Oct 12, 2025
|
|
||
| function mergeOptionsWithDefaults(options?: CompareOptions): Required<CompareOptions> { | ||
| return { | ||
| combinePages: options?.combinePages ?? true, |
Author
There was a problem hiding this comment.
Default for this option is kept as true to ensure this is a non-breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the
combinePagesoption to allow diffing PDFs per page rather than combining all images into one. This is useful when diffing large (20+ page) PDFs.Fixes #97