Omit more debug logs by default#688
Open
GreemDev wants to merge 2 commits intomonkeyman192:developmentfrom
Open
Omit more debug logs by default#688GreemDev wants to merge 2 commits intomonkeyman192:developmentfrom
GreemDev wants to merge 2 commits intomonkeyman192:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These ones actually weren't under any compile guard, meaning the logic for creating the strings was always executing even if nothing was logged.
I noticed this causing notable slowdown in Debug (much like my other changes) (because it actually logs), but these changes should actually benefit everyone, even if marginal.