Skip to content

ci: use toolchain python in windows#4954

Merged
tadjik1 merged 1 commit into
mainfrom
fix-python-windows-fails
Jun 4, 2026
Merged

ci: use toolchain python in windows#4954
tadjik1 merged 1 commit into
mainfrom
fix-python-windows-fails

Conversation

@PavelSafronov
Copy link
Copy Markdown
Contributor

Description

Summary of Changes

For Windows, use installed Python.

What is the motivation for this change?

We are seeing sporadic Python failures where the wrong Python is used and results in errors like this:

ModuleNotFoundError: No module named '_ctypes'

Guidance from dbx-devs is to use the toolchain Python for Windows.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@PavelSafronov PavelSafronov marked this pull request as ready for review June 3, 2026 19:19
@PavelSafronov PavelSafronov requested a review from a team as a code owner June 3, 2026 19:19
Copilot AI review requested due to automatic review settings June 3, 2026 19:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Evergreen dependency installation script to consistently select the drivers toolchain Python on Windows, reducing sporadic node-gyp failures caused by the wrong Python being picked up (e.g., missing _ctypes).

Changes:

  • Force NODE_GYP_FORCE_PYTHON to be set on Windows (in addition to native builds) before running npm install.

@tadjik1 tadjik1 self-assigned this Jun 4, 2026
@tadjik1 tadjik1 added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 4, 2026
@tadjik1 tadjik1 merged commit fd940fe into main Jun 4, 2026
36 checks passed
@tadjik1 tadjik1 deleted the fix-python-windows-fails branch June 4, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants