test(NODE-7426): Add appName to OIDC test failpoints by PavelSafronov · Pull Request #4869 · mongodb/node-mongodb-native

PavelSafronov · 2026-02-09T18:13:44Z

Description

Summary of Changes

Updated OIDC test specs.
Double-checked that failpoints are being removed
Updated UnifiedMongoClient to always configure an appName, as either a passed-in value or a unique identifier, as called out for OIDC tests in mongodb/specifications@4d11668

Double check the following

Lint is passing (npm run check:lint)
Self-review completed using the steps outlined here
PR title follows the correct format: type(NODE-xxxx)[!]: description
- Example: feat(NODE-1234)!: rewriting everything in coffeescript
Changes are covered by tests
New TODOs have a related JIRA ticket

dariakp · 2026-02-18T19:40:10Z

test/tools/unified-spec-runner/entities.ts

    }

+    // Test descriptions use `appName` and `appname` interchangeably
+    if (


You should not need to modify the unified test runner, since there was no change to the unified test runner specification. The appName for unified tests is already passed in directly via the spec files themselves.

You may find it helpful to look at the reference implementations linked in the spec PR (mongodb/specifications#1891), for example the python one here.

Thanks for explaining, tests are updated and this change is reverted.

dariakp · 2026-02-18T19:56:33Z

test/integration/auth/mongodb_oidc.prose.test.ts

        });

        afterEach(async function () {
+          // explicitly remove the fail point to prevent interaction betweet test runs


The annotations are helpful, however, the new requirement in the spec is to ensure that we not only remove the failpoint but also always set the appName for any failpoint created. In this file, there are two types of clients - the regular one and the util client (with the util clients being used to set fail points), with some clients instantiated via new MongoClient and others via the getClient method, so we want to make sure that we always configure the clients being tested and the failpoints set in the test with an appName.

Thanks for the explanation, added an appName generator and using that in tests, with the same app name for each pair of client and util clients.

- configured a distinct per-test appName - removed generated appName

Copilot

Pull request overview

Updates OIDC authentication tests to scope server failpoints by appName (per updated OIDC spec guidance) and to explicitly clean up failpoints between test runs, reducing cross-test interference.

Changes:

Add serverless: forbid to the unified OIDC no-retry spec test.
Configure a stable appName in the unified spec test client and include appName in failpoint data.
Update OIDC prose integration tests to generate unique appName values per describe block, pass them to clients, and attempt explicit failpoint teardown.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 17 comments.

File	Description
test/spec/auth/unified/mongodb-oidc-no-retry.yml	Adds `serverless: forbid`, introduces `appName` anchor, and scopes failpoints via `appName`.
test/spec/auth/unified/mongodb-oidc-no-retry.json	JSON equivalent of the unified spec updates (serverless forbid, appName, appName-scoped failpoints).
test/integration/auth/mongodb_oidc.prose.test.ts	Adds per-test `appName` generation, passes `appName` into clients and failpoints, and adds explicit failpoint cleanup (with issues noted in PR comments).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-20T22:27:43Z

test/integration/auth/mongodb_oidc.prose.test.ts

            configureFailPoint: 'failCommand',
-            mode: 'off'
+            mode: 'off',
+            data: { appName }


When disabling the failCommand failpoint, the command currently sends data: { appName } only. The server-side failCommand failpoint expects data.failCommands (see FailCommandFailPoint in test/tools/utils.ts), so this payload may be rejected or fail to disable the intended failpoint. Include the same failCommands (and appName) used when enabling the failpoint.

Suggested change

data: { appName }

data: { failCommands: ['find'], appName }

Copilot · 2026-02-20T22:27:44Z

test/integration/auth/mongodb_oidc.prose.test.ts

            configureFailPoint: 'failCommand',
-            mode: 'off'
+            mode: 'off',
+            data: { appName }


When disabling the failCommand failpoint, the command currently sends data: { appName } only. The server-side failCommand failpoint expects data.failCommands (see FailCommandFailPoint in test/tools/utils.ts), so this payload may be rejected or fail to disable the intended failpoint. Include the same failCommands (and appName) used when enabling the failpoint.

Suggested change

data: { appName }

data: { failCommands: ['saslStart'], appName }

Copilot · 2026-02-20T22:27:44Z

test/integration/auth/mongodb_oidc.prose.test.ts

            configureFailPoint: 'failCommand',
-            mode: 'off'
+            mode: 'off',
+            data: { appName }


When disabling the failCommand failpoint, the command currently sends data: { appName } only. The server-side failCommand failpoint expects data.failCommands (see FailCommandFailPoint in test/tools/utils.ts), so this payload may be rejected or fail to disable the intended failpoint. Include the same failCommands (and appName) used when enabling the failpoint.

Suggested change

data: { appName }

data: { failCommands: ['insert'], appName }

Copilot · 2026-02-20T22:27:44Z

test/integration/auth/mongodb_oidc.prose.test.ts

            configureFailPoint: 'failCommand',
-            mode: 'off'
+            mode: 'off',
+            data: { appName }


When disabling the failCommand failpoint, the command currently sends data: { appName } only. The server-side failCommand failpoint expects data.failCommands (see FailCommandFailPoint in test/tools/utils.ts), so this payload may be rejected or fail to disable the intended failpoint. Include the same failCommands (and appName) used when enabling the failpoint.

Suggested change

data: { appName }

data: {

failCommands: ['find'],

appName

}

Copilot · 2026-02-20T22:27:44Z

test/integration/auth/mongodb_oidc.prose.test.ts

            configureFailPoint: 'failCommand',
-            mode: 'off'
+            mode: 'off',
+            data: { appName }


When disabling the failCommand failpoint, the command currently sends data: { appName } only. The server-side failCommand failpoint expects data.failCommands (see FailCommandFailPoint in test/tools/utils.ts), so this payload may be rejected or fail to disable the intended failpoint. Include the same failCommands (and appName) used when enabling the failpoint.

Suggested change

data: { appName }

data: {

failCommands: ['find'],

appName

}

Copilot · 2026-02-20T22:27:46Z

test/integration/auth/mongodb_oidc.prose.test.ts

          await utilClient.db().admin().command({
            configureFailPoint: 'failCommand',
-            mode: 'off'
+            mode: 'off',
+            data: { appName }
          });


When disabling the failCommand failpoint, the command currently sends data: { appName } only. The server-side failCommand failpoint expects data.failCommands (see FailCommandFailPoint in test/tools/utils.ts), so this payload may be rejected or fail to disable the intended failpoint. Include the same failCommands (and appName) used when enabling the failpoint.

Copilot · 2026-02-20T22:27:46Z

test/integration/auth/mongodb_oidc.prose.test.ts

+          client = getClient({ promoteValues: false, appName }, callbackSpy);
+          utilClient = getClient({ promoteValues: false, appName }, createCallback());
          collection = client.db('test').collection('test');
          await utilClient
            .db()


The failpoint configured in this test should be scoped with appName to avoid impacting other OIDC prose tests. In this describe block, the client is created with an appName but the failCommand configuration later in the setup does not include appName in its data, so the failpoint can apply globally.

Copilot · 2026-02-20T22:27:47Z

test/integration/auth/mongodb_oidc.prose.test.ts

            configureFailPoint: 'failCommand',
-            mode: 'off'
+            mode: 'off',
+            data: { appName }


When disabling the failCommand failpoint, the command currently sends data: { appName } only. The server-side failCommand failpoint expects data.failCommands (see FailCommandFailPoint in test/tools/utils.ts), so this payload may be rejected or fail to disable the intended failpoint. Include the same failCommands (and appName) used when enabling the failpoint.

Suggested change

data: { appName }

data: { failCommands: ['find'], appName }

Copilot · 2026-02-20T22:27:47Z

test/integration/auth/mongodb_oidc.prose.test.ts

            configureFailPoint: 'failCommand',
-            mode: 'off'
+            mode: 'off',
+            data: { appName }


When disabling the failCommand failpoint, the command currently sends data: { appName } only. The server-side failCommand failpoint expects data.failCommands (see FailCommandFailPoint in test/tools/utils.ts), so this payload may be rejected or fail to disable the intended failpoint. Include the same failCommands (and appName) used when enabling the failpoint.

Suggested change

data: { appName }

data: {

failCommands: ['insert'],

appName

}

Copilot · 2026-02-20T22:27:47Z

test/integration/auth/mongodb_oidc.prose.test.ts

            configureFailPoint: 'failCommand',
-            mode: 'off'
+            mode: 'off',
+            data: { appName }


When disabling the failCommand failpoint, the command currently sends data: { appName } only. The server-side failCommand failpoint expects data.failCommands (see FailCommandFailPoint in test/tools/utils.ts), so this payload may be rejected or fail to disable the intended failpoint. Include the same failCommands (and appName) used when enabling the failpoint.

Suggested change

data: { appName }

data: {

failCommands: ['find'],

appName

}

PavelSafronov added 2 commits February 9, 2026 10:13

test(NODE-7426): Add appName to OIDC test failpoints

5d3d3fc

removed commits

553631d

PavelSafronov force-pushed the NODE-7426 branch from 7cdb6ac to 553631d Compare February 10, 2026 19:56

PavelSafronov marked this pull request as ready for review February 10, 2026 20:07

PavelSafronov requested a review from a team as a code owner February 10, 2026 20:07

dariakp self-assigned this Feb 18, 2026

dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 18, 2026

dariakp requested changes Feb 18, 2026

View reviewed changes

pr feedback:

f5c5846

- configured a distinct per-test appName - removed generated appName

Copilot AI review requested due to automatic review settings February 20, 2026 22:22

Copilot started reviewing on behalf of PavelSafronov February 20, 2026 22:22 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

	data: { appName }
	data: { failCommands: ['saslStart'], appName }

	data: { appName }
	data: { failCommands: ['insert'], appName }

Comments

Conversation

PavelSafronov commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Summary of Changes

Double check the following

Uh oh!

dariakp Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

PavelSafronov Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

dariakp Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

PavelSafronov Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

PavelSafronov commented Feb 9, 2026 •

edited

Loading